Gordon,
My previous test was incorrect. I've reproduced the problem and verified the fix below.
Thanks very much for isolating this!
If anyone would like a JE jar file with this fix, please email me at my oracle address: mark.hayes
This bug causes a memory leak for applications where both of the following are true:
- Many Environment objects are opened and closed.
- The CurrentTransaction or TransactionRunner class is used.
Mark
--------
*** src/com/sleepycat/collections/CurrentTransaction.java 1 Feb 2007 14:49:39 -0000 1.46.2.1
--- src/com/sleepycat/collections/CurrentTransaction.java 12 Apr 2007 16:02:18 -0000
***************
*** 8,13 ****
--- 8,14 ----
package com.sleepycat.collections;
+ import java.lang.ref.WeakReference;
import java.util.ArrayList;
import java.util.List;
import java.util.WeakHashMap;
***************
*** 71,80 ****
*/
static CurrentTransaction getInstanceInternal(Environment env) {
synchronized (envMap) {
! CurrentTransaction myEnv = (CurrentTransaction) envMap.get(env);
if (myEnv == null) {
myEnv = new CurrentTransaction(env);
! envMap.put(env, myEnv);
}
return myEnv;
}
--- 72,85 ----
*/
static CurrentTransaction getInstanceInternal(Environment env) {
synchronized (envMap) {
! CurrentTransaction myEnv = null;
! WeakReference myEnvRef = (WeakReference) envMap.get(env);
! if (myEnvRef != null) {
! myEnv = (CurrentTransaction) myEnvRef.get();
! }
if (myEnv == null) {
myEnv = new CurrentTransaction(env);
! envMap.put(env, new WeakReference(myEnv));
}
return myEnv;
}
Hi Gordon,
Thanks, Mark!