DevOps, CI/CD and Automation

There is not enough data yet for me to tell whether this is a Sun Studio compiler bug, invalid code that happens to be accepted by g++, or something else.

Please show the declarations for
vtkOpenGLExtensionManagerFunctionPointer
__GLXextFuncPtr
GLubyte
fname

as i already said, i'm a dev, i only get the tarball here:
http://www.paraview.org/files/v3.4/paraview-3.4.0.tar.gz

to reply to you as fast as possible, the complete log is available here:
http://www.latp.univ-mrs.fr/~henry/Solaris/x86/MAKE6.LOG

the file concerned is ./ParaView-3.4.0/VTK/Rendering/vtkOpenGLExtensionManager.cxx

i'm unable to give you a short example to highlight the behaviour of sunstudio.

thanks for your help,

gerard

I can't debug large applications like this for you. I can evaluate compiler bugs.

I tried the compilation line that failed, substituting the path where I unpacked ParaView for your path, but some files come up missing.

Please run the CC command that failed, but substitute -E for the -c option, and redirect all output into a file. Example:

CC <options> vtkOpenGLExtensionManager.cxx -E >& vtkOpenGLExtensionManager.i

Move the .i file to a an empty directory, and try to compile it as
CC -c vtkOpenGLExtensionManager.i
You should see the same error messages. If so, post your email address here, and I'll tell you where to send the file.

here are what i obtain:

henry@ultra20:/tmp/toot$ CC -c vtkOpenGLExtensionManager.i
"vtkOpenGLExtensionManager.h", line 140: Error: In this declaration "vtkOpenGLExtensionManager" is of an incomplete type "VTK_RENDERING_EXPORT".
"vtkOpenGLExtensionManager.h", line 140: Error: "," expected instead of ":".
"vtkOpenGLExtensionManager.h", line 144: Error: vtkOpenGLExtensionManager, of type int, was previously declared VTK_RENDERING_EXPORT.
"vtkOpenGLExtensionManager.h", line 144: Error: Multiple declaration for vtkOpenGLExtensionManager.
"vtkOpenGLExtensionManager.h", line 144: Error: "," expected instead of "*".
"vtkOpenGLExtensionManager.h", line 145: Error: ostream is not defined.
"vtkOpenGLExtensionManager.h", line 151: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 155: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 160: Error: ExtensionsString is not defined.
"vtkOpenGLExtensionManager.h", line 164: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 170: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 179: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 187: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 257: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 259: Error: A declaration was expected instead of "protected".
"vtkOpenGLExtensionManager.h", line 260: Error: Multiple declaration for vtkOpenGLExtensionManager.
"vtkOpenGLExtensionManager.h", line 261: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 261: Error: Type name expected instead of "vtkOpenGLExtensionManager".
"vtkOpenGLExtensionManager.h", line 261: Error: Illegal number of arguments for ~file level().
"vtkOpenGLExtensionManager.h", line 263: Error: Template vtkWeakPointer is not defined.
"vtkOpenGLExtensionManager.h", line 268: Error: vtkTimeStamp is not defined.
"vtkOpenGLExtensionManager.h", line 270: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 277: Error: "virtual" is not allowed here.
"vtkOpenGLExtensionManager.h", line 279: Error: A declaration was expected instead of "private".
"vtkOpenGLExtensionManager.h", line 280: Error: ")" expected instead of "&".
Compilation aborted, too many Error messages.

my email is ghenry_at_cmi.univ-mrs.fr

thanks for your help,

gerard

I'm taking this discussion off line for now.

Here are the results of my investigation.

The code in ParaView is actually invalid, but is accepted by g++.

The code in question when stripped down looks like this:

typedef unsigned char GLubyte;

typedef void ( * __GLXextFuncPtr ) ( void ) ; // implicitly extern "C++"
extern "C" {
typedef void ( * vtkOpenGLExtensionManagerFunctionPointer ) ( void ) ;
}

extern "C"
__GLXextFuncPtr  vtkglX :: glXGetProcAddressARB ( const GLubyte * ) ;


vtkOpenGLExtensionManagerFunctionPointer
vtkOpenGLExtensionManager :: GetProcAddress ( const char * fname )
{
    // ...
    return static_cast < vtkOpenGLExtensionManagerFunctionPointer >
    ( glXGetProcAddressARB( reinterpret_cast< const GLubyte* > (fname) ) ) ;
}

This code fragment is not compilable since some declarations are missing, but it shows the error.

In the return statement, the return value of glXGetProcAddressARB is converted via a static cast to type vtkOpenGLExtensionManagerFunctionPointer. The problem is that glXGetProcAddressARB returns a pointer to an extern "C++" function, but type vtkOpenGLExtensionManagerFunctionPointer is a pointer to an extern "C" function. The two function kinds are not compatible.

g++ incorrectly allows the conversion via a static_cast. Sun C++ and another compiler I tried do not allow it.

The simplest fix is to change the static_cast to a reinterpret_cast, which allows this kind of pointer conversion.

But on a system where C and C++ functions have different calling sequences, the code would not run correctly even if it compiled. I do not know of any such systems currently, but I would not be surprised to see some.

The correct fix is to match up the C and C++ function types, or to use proxy functions to convert between C and C++ function declarations. The C++ Migration Guide in section 3.11 discusses this topic in detail, with examples.
http://docs.sun.com/source/819-3689/Ch3.Std.html#pgfId-18041