Hi,
I had a look at the script "sql" that comes packaged with SQLcl and came up with some points for potential enhancements:
- Style:
- Indentation is not uniform.
- Brace placement for functions is not uniform.
- if then placement is not uniform.
- Code placed in comments can probably be removed.
- I recommend running "shellcheck" for a list of potential issues.
Points are mainly cosmetic but then again I didn't dig deep, either way I think clean code goes a long way even if it is just a bash script.
Message was edited by: Jack Trocinski - Added a sentence clarifying what this post is about.