Refactor SQLcl "sql" Script?

Jack Trocinski

Hi,

I had a look at the script "sql" that comes packaged with SQLcl and came up with some points for potential enhancements:

• Style:
  • Indentation is not uniform.
  • Brace placement for functions is not uniform.
  • if then placement is not uniform.
  • Code placed in comments can probably be removed.
• I recommend running "shellcheck" for a list of potential issues.

Points are mainly cosmetic but then again I didn't dig deep, either way I think clean code goes a long way even if it is just a bash script.

Message was edited by: Jack Trocinski - Added a sentence clarifying what this post is about.

Glen Conway

This may be a moot point.  The latest releases (18.1.x) do not ship with a sql.bat file, as noted in:

sql.bat not found in sqlcl-18.1.0 download

And if no one on the SQL Developer team responds saying this omission was unintentional, then I would assume sql.bat is dead.  After all, SQL*Plus on WIndows is provided via a sqlplus.exe, there is no sqlplus.bat.  Probably SQL Developer / SQLcl is following the same model.

thatJeffSmith-Oracle

it'll maybe/probably come back

Jack Trocinski

I should have been more specific, this was in reference to the Bash file that comes with 18.1.1 named "sql".

Glen Conway

Interesting. That will make very happy any users whose specific environment configuration needs are not currently met by sql.exe.

Glen Conway

And I should have read your post more carefully.  Sorry.