List of forum editor issues and bugs

Dude! · Jan 7, 2014 11:05PM

This thread is work in progress. Please report additional bugs and issues you are aware off. I will try to reproduce the issue and add your information to the appropriate columns below. Thanks!

Note: For accurate results, the width of your web browser window needs to be adjusted to show the following dotted line as a single line. Your screen resolution needs to be at least 1280 pixels wide.

. . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .

Issue	Date	Summary	Browser	Status	Remark
1	08-Jan-2014 last verified 24-Aug-2014	Text copied from discussions, such as code, result in double line spacing when copied to the host system.	Firefox Internet Explorer Safari Chrome	open open fixed fixed	1.1 1.2
2	08-Jan-2014 last verified 23-Aug-2014	Cannot append text or code to Syntax Highlighting.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
3	08-Jan-2014 last verified 23-Aug-2014	Cannot properly select text or code with Syntax Highlighting.	Firefox Internet Explorer Safari Chrome	improved fixed fixed fixed	3.1
4	08-Jan-2014 last verified 23-Aug-2014	Subsequent edit sessions add empty lines to Syntax Highlighting code.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
5	08-Jan-2014 last verified 23-Aug-2014	Copying text under Syntax Highlighting includes line numbers.	Firefox Internet Explorer Safari Chrome	improved open fixed fixed	5.1 5.2
6	08-Jan-2014 last verified 23-Aug-2014	Cannot copy and paste the whole Syntax Highlighting frame.	Firefox Internet Explorer Safari Chrome	improved fixed improved improved	6.1 6.3 6.3
7	09-Jan-2014 last verified 23-Aug-2014	Syntax Highlighting suppresses empty lines and white space when browsing.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
8	08-Jan-2014 last verified 23-Aug-2014	Syntax Highlighting overwrites font.	Firefox Internet Explorer Safari Chrome	improved improved improved improved	8.1 8.1 8.1 8.1
9	09-Jan-2014 last verified 23-Aug-2014	Cannot paste any text into the editor window.	Firefox Internet Explorer 11 Safari Chrome	working fixed working working
10	09-Jan-2014 last verified 23-Aug-2014	Cannot change the font when selecting several lines of text.	Firefox Internet Explorer Safari Chrome	improved working fixed improved	10.1 10.1
11	09-Jan-2014 last verified 23-Aug-2014	Changing the font gets confused and shows the wrong font.	Firefox Internet Explorer Safari Chrome	improved working open open	11.1 11.3 11.3
12	09-Jan-2014 last verified 23-Aug-2014	Pasting a URL captures the text insertion point.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
13	16-Jan-2014 last verified 23-Aug-2014	Quoting captures insertion point.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
14	24-Jan-2014 last verified 23-Aug-2014	Adding HTML label tag for no apparent reason.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
15	28-Feb-2014 last verified 23-Aug-2014	Undo disables functions, such as Quote and Syntax Highlighting and results in complete loss of text when attempting to post.	Firefox Internet Explorer Safari Chrome	Improved working working working	15.1
16	28-Feb-2014 last verified 23-Aug-2014	Syntax Highlighting shows several <span> when browsing.	Firefox Internet Explorer Safari Chrome	fixed fixed fixed fixed
17	23-Jun-2014 last verified 23-Aug-2014	When specifying a table width, typed numbers are falling through and land the table as text.	Firefox Internet Explorer Safari Chrome	open open open open
18	23-Aug-2014	Quoting of content with Syntax Highlighting looks fine when editing, but when posting, quoting around SH is removed.	Firefox Internet Explorer Safari Chrome	open open open open
19	22-Aug-2014	Text like "Patch 11.2.0.3" are converted to non-functional hyperlinks when posting.	Firefox Internet Explorer Safari Chrome	open open open open
20	20-Jul-2014 last verified 23-Aug-2014	The editor toolbar disappears behind the forum banner when scrolling to the next page.	Firefox Internet Explorer Safari Chrome	open open open open
21	17-Nov-2014	Insertion point displayed in text under Syntax Highlighting is not showing the real position.	Firefox	open
22	23-Aug-2014	Hover-up and pop-up menus are in the way then typing text in tables and code under Syntax Highlighting.	Firefox Internet Explorer Safari Chrome	open open open open
23	23-Aug-2014	Copying text from the first post of a thread includes a grey background.	Firefox Internet Explorer Safari Chrome	working working open open
24	24-Aug-2014	Copy and paste does not retain the size of a picture and resizing produces bad quality images. Resizing also no longer shows picture dimensions. Copying images between documents does not copy size settings.	Firefox Internet Explorer Safari Chrome	open open open open
25	17-Nov-2014	Copying and pasting of text determine the source format and creates unwanted or useless tables, affecting also Syntax Highlighting.	Firefox	open
26	17-Nov-2014	Adding additional rows to tables do not inherit the previous cell formats, such as vertical and horizontal center line.	Firefox	working
27	02-Dec-2014	The Jive spell-checker is difficult to use. Pointing and clicking of marked text has to be very precise in order to function, or the spell-checker deactivates itself.	Firefox	open

Ref. No.	Remarks
1.1	Pasting of regular text results in double-line spacing. Pasting of code with Syntax Highlighting does not produce double-line spacing, but includes line numbers when pasting in a rich text editor window, or results in indented lines when pasting to the command prompt or plain text window.
1.2	Pasting of code with Syntax Highlighting includes line numbers when pasting into notepad or to the command prompt. Copying of normal text does not wrap and appears a single line when pasting into notepad.
3.1	Selecting of code and copying works, but selected text looks like a tape and is not visible.
5.1	Copy works find and does not include line numbers, but the text is indented. When pasting text into a rich text enabled editor window, it includes line numbers.
5.2	Code in syntax highlighting does not copy blank lines, but copies line numbers.
6.1	Only parts of a code segment can be copied, but not the complete code segment. Copy and paste always copies an additional line that was actually not selected. https://www.youtube.com/watch?v=9tGybQfWjzM
6.3	Copy and paste only copies the code but not syntax highlighting, which can however be can be re-applied.
8.1	Applying syntax highlighting now applies a font that is suitable for displaying code. However, it is not possible to change the font, if necessary, or apply color or bold or highlighting. Color can be applied, which looks like double-vision, but anyway is removed when posting.
10.1	Not working reliably. Sometimes the last line selected is not changed, or only the first line changes.
11.1	Sometimes fonts are not displayed properly, for instance, the text insertion point may show Arial, but the text is Courier. There is no clear pattern when this happens or what triggers the problem.
11.3	The text insertion point or selected text always reports the font name "font family", regardless of the font applied.
15.1	Ctrl-z aborting editor functions under Firefox on Mac OS X. However, Cmd-z, which is standard, works properly. This problem does not affect Safari. https://www.youtube.com/watch?v=RnOk5dQdOsk

Issue	Steps to reproduce	Workaround
1	Copy a couple or more lines of text from a discussion window and paste it into any application or document on your host system. For instance: The following may produce double line spacing: If there are two or more ways to do something, and one of those ways can result in a catastrophe, then someone will do it. The following should work correctly: If there is a possibility of several things going wrong, the one that will cause the most damage will be the first one to go wrong	Use Shift-Return instead of Return to terminate the end of lines when creating text. Use a different browser to perform cut and paste operations, such as Apple Safari or Google Chrome.
2	Paste some text code into the forum editor window. Select the code and choose Syntax Highlighting:Plain from the editor toolbar (>>). Close and re-edit the thread. It is not possible to place the insertion point below the block of code in order to add any additional lines of code or to add any normal text. For instance: mknod compress_pipe p mknod export_pipe p chmod +rw export_pipe compress_pipe nohup split -b 8192m < export_pipe & nohup gzip < compress_pipe > export_pipe & exp system/passwd full=y direct=y consistent=y compress=n \ buffer=10485760 file=compress_pipe	It is possible to insert additional code or text below Syntax Highlighting, provided the frame it is not the end, as shown in issue 7. Add any line of text at the end of your code before applying Syntax Highlighting to the lines above. Adding code within the frame of Syntax Highlighting works in Safari and Google Chrome.
3	Re-edit a post with Syntax Highlighting. It is not possible to properly select any lines of code. An additional empty code line is added and the focus is shifted. The selection mask does not match the actual text. It is pretty much impossible to re-edit Syntax Highlighting. Screenshot: http://img24.imageshack.us/img24/6121/viun.jpg	Use Safari or Google Chrome when to re-edit text or code under Syntax Highlighting.
4	Every subsequent edit of a post with Syntax Highlighting adds an empty blank line to the code block with an incremented line number. The resulting empty lines (07, 08) shown in the screenshot cannot be selected or removed unless there is text below the code frame as shown in issue 7. Screenshot: http://img809.imageshack.us/img809/5514/cxkd.jpg	Removing of empty lines woks in Safari and Google Chrome.
5	When browsing code with Syntax Highlighting, it is not possible to select the code without the line numbers. Screenshot: http://img835.imageshack.us/img835/6626/j7n7.jpg	Select and copy each line separately. Or use Firefox or Google Chrome, but note issue in Remark 5.
6	When editing, it is possible to copy and paste lines under Syntax Highlighting when selecting the lines, but not when selecting the complete Syntax Highlighting frame.	Carefully select text without the Syntax Highlighting frame boundaries.
7	Empty lines and white space (identation) in Syntax Highlighting are suppressed when browsing, although they exist in the actual post. For instance: mknod compress_pipe p mknod export_pipe p Screenshot when editing the above code: http://img401.imageshack.us/img401/673/kmy4.jpg
8	Syntax Highlighting changes the font to Arial and it is not possible to apply something more suitable for the displaying of code, such as fixed-width Courier New. mknod compress_pipe p Arial: 1l0OI Courier New: 1l0OI Arial: 1l0OI Courier New: 1l0OI
9	It is not possible to paste any text into the editor window.	Use a different web browser or downgrade to IE 10. Or enable F12 Developer Tools from the Tools menu. Press Ctrl-8 Change the default document mode from Edge to IE 10. Select Leave this page.
10	Create a new thread and type several lines of text. Then select select several lines of text and choose a font, e.g. Courier New. Not all selected lines are changed and only a couple of lines remain highlighted. For instance: It is difficult to prove the existence of aliens. Photos exist with aliens, but they could be fake. On the other hand, photos without aliens could be fake too.
11	Select a line of text and change the font to Courier New. Then select the line again and it will show Arial. Change the font to Courier New and the text will change back to Arial.
12	Copy a URL and paste it into the editor window. The URL will be shown as a hyperlink using blue text. It is not possible to continue with normal writing without changing the text of the link. The text insertion point is captured inside the text of the link when trying to click below the link.	After pasting the URL, use the arrow key or mouse to move the cursor to the end of the link, then press RETURN and start writing normally. You can than move the cursor to the beginning of the line and use BACKSPACE to move the text up, after the link.
13	When replying to a thread and pressing the Quote Previous Message button and then clicking inside the quoted text, for instance, to remove some of the content, it is sometimes no longer possible to move the text insertion point outside of the quoted text back to the normal editing area.	When this happens it helps to switch to HTML and then switch back to the Full Editor.
14	While writing normal text in the editor, it sometimes becomes impossible to edit a line of text. When clicking on any text to move the text insertion point, it selects the complete paragraph instead. http://imagizer.imageshack.us/v2/800x600q90/585/d0v5.jpg. When pressing the "Post Message" button, a dialog appears to "Stay" or "Leave" the page.	Apparently the editor adds HTML label tags for no apparent reason, which can be seen when switching the editor to HTML mode. http://imagizer.imageshack.us/v2/800x600q90/199/1r5a.jpg
15	Copy some text into the editor window. Select the text and choose Syntax Highlighting form the >> insert toolbar. Undo using Ctrl-z. It is no longer possible to use any of the >> insert functions. After that it is also not possible to post the message, resulting in an unexpected error and the content is lost.
16	Syntax Highlighting shows several <span> at the beginning and end of the Syntax Highlighting block after posting. This affects old and new posts.
17	When changing the width of a table column, entering the 2nd number gets punched into the cell content instead. https://www.youtube.com/watch?v=g_ZoRoHzAoI	After entering the first number, click in the entry field again to enter the 2nd number.
18	https://www.youtube.com/watch?v=e3EolAX4AEc
19	Automatic insertion of links to support.oracle.com contains more info, including responses from Oracle staff.
20	https://www.youtube.com/watch?v=VQgugxQvYQ0	Change the width of browser window until the editor toolbar appears. It will then stay on top when scrolling through pages.
21	Select Syntax Highlighting, Plain from the >> insert menu, then copy and past several lines of text (code) into it. Or, copy and paste the text, then mark the text with the mouse and select SH from the insert menu. Many times, the insertion point is not reflecting it's actual position when you click inside the text. Very often it is also not possible to position the insertion point to the end or beginning of a line using the left and right arrow keys; the insertion point jumps to the next line, even though the end of the line has not been reached. For instance: The text insertion point [\|] is showing up between the words "point" and "is", but when pressing the delete key or entering text, it affects a different area.
22	https://www.youtube.com/watch?v=tBSOvc_8sHI The following is a picture with text and Syntax Highlighting.	In tables, pressing the delete key will remove or rearrange the hover-up window.
23	The original or initial post of a thread is shown with a grey background when browsing. Depending on the web browser application, this background is also copied when doing a copy and paste of the text, provided the target window supports rich text editing. https://www.youtube.com/watch?v=pOvIzug-Vj0	Change the target editor window to plain text.
24	After resizing a pasted image to the same size than the original, the quality is much worse. The following shows a screenshot of the original and copied image: When resizing a picture by moving the image end-points, the editor does no longer show the current picture dimensions (pixel x pixel) as it did in Jive 5. Also when copying a picture between documents, the picture is enlarged and requires resizing.
25	Copy and paste content from /etc/oratab, for example: The same also happens when pasting the text into a Syntax Highlighting field. It is often necessary to use undo (ctrl-z, cmd-z) to get rid of the mess.
26	Please see below screenshot:
27	https://www.youtube.com/watch?v=rBpGdQqJuxY

Message was edited by: Dude!

moniquevdb-Oracle · Jan 8, 2014 6:53PM

Holy.... wow, this is helpful, thank you so much for kicking this off, @Dude!

@BluShadow I know you are in favor of reenabling code formatting and ditching the Syntax Highlighter altogether. I've also heard that users would prefer the advanced editor to open by default. Anything else on the wishlist?

Dude! · Jan 8, 2014 10:09PM

Thanks, glad to help! There is still a lot left to do though.

I think the advanced forum editor is really not that much advanced for anyone with a computer background. But my heartbeat increases when I have to switch to the advanced editor to reach for the “remove formatting” button. So If you ask me, please make the advanced editor the default.

Regarding Syntax Highlighting, I prefer a button solution, which makes selected text appear similar to the previous forum when using the {code} tags. It made text appear in a fixed-width font and added a frame with a grey background and horizontal scroll bar when necessary to prevent automatic line wrapping. I do not want any line numbers to be added and no suppressing of empty lines or computer paper background. I would however like to be able to change the font style and color of individual text fragments.

BluShadow · Jan 9, 2014 3:36AM

moniquevdb_oracle wrote:

Holy.... wow, this is helpful, thank you so much for kicking this off, Dude!

BluShadow I know you are in favor of reenabling code formatting and ditching the Syntax Highlighter altogether. I've also heard that users would prefer the advanced editor to open by default. Anything else on the wishlist?

correction, I would certainly be in favour (favor to you ) of reenabling code tags, mainly because I work quicker by copy/paste and by keyboard than by having to click through a load of buttons (that currently don't do what they should). I've not said that syntax highlighting should be ditched altogether, and I'd certainly be in favour of it being there, just so long as it provided a decent formatting that was appropriate, so code actually looked like code, and the ability for people to copy/paste the code out of the forum to their own environment wasn't corrupted with double line spacing (as dude has already mentioned) and the addition of the line numbers it puts in (the line numbers are useful for reference on the forum, e.g. when we want to say "you're problem is on line X", but not good when you copy/paste code out to your environment and have to spend ages deleting them all to get the code to do anything). If it's too difficult, then removing the line numbers from the code formatting would be preferable to having them there and not being able to copy the code out without them.

I agree with dude that it would be good to be able to highlight portions of code with bold or colours, which the old forum didn't allow, but this one does, so it's really a combination of old and new that's needed. And as dude highlights, the supressing of blank lines is a pain as it can make the posting of multiple code commands become all compressed and difficult to read, and is not representative of what we have in our interfaces such as SQL*Plus etc.

Basic example:

Copy paste from my SQL*Plus window into the forum (and me applying courier new and quoting it)...

SQL> select * from emp;
     EMPNO ENAME      JOB              MGR HIREDATE                    SAL       COMM     DEPTNO
---------- ---------- --------- ---------- -------------------- ---------- ---------- ----------
      7369 SMITH      CLERK           7902 17-DEC-1980 00:00:00        800                    20
      7499 ALLEN      SALESMAN        7698 20-FEB-1981 00:00:00       1600        300         30
      7521 WARD       SALESMAN        7698 22-FEB-1981 00:00:00       1250        500         30
      7566 JONES      MANAGER         7839 02-APR-1981 00:00:00       2975                    20
      7654 MARTIN     SALESMAN        7698 28-SEP-1981 00:00:00       1250       1400         30
      7698 BLAKE      MANAGER         7839 01-MAY-1981 00:00:00       2850                    30
      7782 CLARK      MANAGER         7839 09-JUN-1981 00:00:00       2450                    10
      7788 SCOTT      ANALYST         7566 19-APR-1987 00:00:00       3000                    20
      7839 KING       PRESIDENT            17-NOV-1981 00:00:00       5000                    10
      7844 TURNER     SALESMAN        7698 08-SEP-1981 00:00:00       1500          0         30
      7876 ADAMS      CLERK           7788 23-MAY-1987 00:00:00       1100                    20
      7900 JAMES      CLERK           7698 03-DEC-1981 00:00:00        950                    30
      7902 FORD       ANALYST         7566 03-DEC-1981 00:00:00       3000                    20
      7934 MILLER     CLERK           7782 23-JAN-1982 00:00:00       1300                    10
14 rows selected.
SQL> select * from dept;
    DEPTNO DNAME          LOC
---------- -------------- -------------
        10 ACCOUNTING     NEW YORK
        20 RESEARCH       DALLAS
        30 SALES          CHICAGO
        40 OPERATIONS     BOSTON
SQL>

but in my SQL*Plus window it looks like.

SQL> select * from emp;

     EMPNO ENAME      JOB              MGR HIREDATE                    SAL       COMM     DEPTNO
---------- ---------- --------- ---------- -------------------- ---------- ---------- ----------
      7369 SMITH      CLERK           7902 17-DEC-1980 00:00:00        800                    20
      7499 ALLEN      SALESMAN        7698 20-FEB-1981 00:00:00       1600        300         30
      7521 WARD       SALESMAN        7698 22-FEB-1981 00:00:00       1250        500         30
      7566 JONES      MANAGER         7839 02-APR-1981 00:00:00       2975                    20
      7654 MARTIN     SALESMAN        7698 28-SEP-1981 00:00:00       1250       1400         30
      7698 BLAKE      MANAGER         7839 01-MAY-1981 00:00:00       2850                    30
      7782 CLARK      MANAGER         7839 09-JUN-1981 00:00:00       2450                    10
      7788 SCOTT      ANALYST         7566 19-APR-1987 00:00:00       3000                    20
      7839 KING       PRESIDENT            17-NOV-1981 00:00:00       5000                    10
      7844 TURNER     SALESMAN        7698 08-SEP-1981 00:00:00       1500          0         30
      7876 ADAMS      CLERK           7788 23-MAY-1987 00:00:00       1100                    20
      7900 JAMES      CLERK           7698 03-DEC-1981 00:00:00        950                    30
      7902 FORD       ANALYST         7566 03-DEC-1981 00:00:00       3000                    20
      7934 MILLER     CLERK           7782 23-JAN-1982 00:00:00       1300                    10

14 rows selected.

SQL> select * from dept;

    DEPTNO DNAME          LOC
---------- -------------- -------------
        10 ACCOUNTING     NEW YORK
        20 RESEARCH       DALLAS
        30 SALES          CHICAGO
        40 OPERATIONS     BOSTON

SQL>

Obviously that's a basic example; in reality we can be providing a solution to someone, explaining multiple steps and commands to demonstrate their issue and the solution, and having to go back through the code once we've pasted it adding back in all the line spacings, is a real pain and time consuming.

Certainly, having the advanced editor options available immediately for replying would be better than having to switch to it manually, especially as most people using these forums are going to want to paste code in (what with it being a technical forum and not really a social forum), and the basic editor just doesn't allow for any suitable code formatting (unless the person is mad enough to switch to HTML mode).

Christian Erlinger · Jan 9, 2014 4:52AM

I would certainly be in favour (favor to you  ) of reenabling code tags, mainly because I work quicker by copy/paste and by keyboard than by having to click through a load of buttons (that currently don't do what they should).

+1. I really miss the [code] (or {code}) tags.

Just a wish for the syntax highlighting (I understand if it isn't possible at all): it might be plagiarism, but the code plugin of dokuwiki allows to set the used syntax highlighting in the code tag as well like:

<code plsql>
some_plsql_code;
</code>

or

<code cpp>
some_cplusplus_code;
</code>

maybe something like that could prove useful to the non-WYSIWYG editor zealots like me?

cheers

Dude! · Jan 9, 2014 8:51AM

Code must also not be wrapped and may need a horizontal scroll bar depending on the width of the browser window. It should also allow any character and should not call special internal functions when running into @ and # signs.

The tags used in the previous forum actually made it difficult to maintain useful copies for my own archive. So I usually ended up editing two versions of one and the same document: a forum version and a local copy. I was happy to see that the new forum uses HTML and is WYSIWIG, so I thought I could standardize on HTML. In practice however, copying HTML between the forum and any other editor produces unpredictable results because the forum editor is stripping and converting HTML.

Whether to type {code} tags or selecting text and pushing a button does not really make a different to me. Typing {code} tags as opposed to pushing a button may conflict with the WYSIWIG feature of the editor. I doubt that you can have both options at the same time.

Btw, speaking of WYSIWG, what you edit is not necessarily what you get because the discussion browser is about 1/3 smaller than the editor window due to the action items shown at the right hand side. This means there is going to be automatic wrapping of text, which is bad for tables and code.

BluShadow · Jan 9, 2014 9:30AM

Dude! wrote:
   
Whether to type {code} tags or selecting text and pushing a button does not really make a different to me. Typing {code} tags as opposed to pushing a button may conflict with the WYSIWIG feature of the editor. I doubt that you can have both options at the same time.

No reason you can't have both options. After all the editor seems quite happy to convert : ) into as you type.

jgarry · Jan 9, 2014 12:27PM

BluShadow wrote:



Certainly, having the advanced editor options available immediately for replying would be better than having to switch to it manually, especially as most people using these forums are going to want to paste code in (what with it being a technical forum and not really a social forum), and the basic editor just doesn't allow for any suitable code formatting (unless the person is mad enough to switch to HTML mode).

It looks to me like switching into the advanced editor is actually doing some HTML pre-processing (that window that appears on the left with a bunch of HTML code, before it presents the post in the editor). Perhaps that is the source of all the problems.

I'd like to have the advanced editor options available immediately too, just not an editor this "advanced." (Now humming "Jocko Homo.")

Dude! · Jan 9, 2014 1:12PM

Well, I don't know, but I think catching keystrokes like , which gets converted right away might be different than more complex processing using {code} tags. Text between {code} tags will probably need to be converted to some html when submitting, then how can the editor rebuild the content using the original {code} tags when re-editing? Anyway, I would leave it up to the developer to think about it. Either way, button or tag is fine with me.

moniquevdb-Oracle · Jan 9, 2014 2:26PM

Thanks, this makes sense. Keep the ideas coming in this thread and in the meantime I will keep working on it from my end and see what we can do.

Dude! · Jan 9, 2014 3:49PM

I think I'm pretty much done covering the issues I have run into without doing anything fancy or advanced. If anybody can add something to the list, please reply.

I'm not sure if it makes sense to continue to test the results in different browsers, because I think the editor should work with all common browsers and recent versions worth mentioning.

Forum Stats

Quick Links

Categories

List of forum editor issues and bugs

Comments