Would LIke a Review of My Trigger for Efficiency

Hi Folks

I have created a trigger that seems to work but I would like to ask anyone that has written triggers if i
have created this one in the most efficient manner.

I have very little experience writing triggers at this time, so would appreciate any opinions
on my code.

Basically, the trigger is set on a table called dauditnew that fires when a record is inserted with an auditstr='Login'

It then either inserts a record or updates an existing record in a table called ll_last_logon

Thanks
Jim

CREATE OR REPLACE TRIGGER ll_last_logon_insert